Fix #7387: Specify buffers in regl.clear() to avoid performance warning #7390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvwilson
added
feature
|
This PR looks good to me. Please add a draft log as described here: https://github.com/plotly/plotly.js/tree/master/draftlogs Also it would be great if you add a jasmine test possibly in test/jasmine/tests/scattergl_test.js to lock the bug you fixed in this PR. Thank you! |
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #7387 by specifying the
coloranddepthbuffers in theregl.clear()call insrc/traces/scattergl/plot.js. This prevents the "Performance warning: clear() called with no buffers in bitmask" warning.Changes:
regl.clear({})toregl.clear({ color: true, depth: true }).